Re: ATTACH/DETACH PARTITION CONCURRENTLY

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>

Cc: Michael Paquier <michael@paquier.xyz>, David Rowley <david.rowley@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Simon Riggs <simon@2ndquadrant.com>

Date: 2018-11-16T14:38:40Z

Lists: pgsql-hackers

Attachments

v3-0001-Reduce-unnecessary-list-construction-in-RelationB.patch (application/octet-stream) patch v3-0001

On Thu, Nov 15, 2018 at 8:58 PM Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
> The partition_bounds_copy() is not because of your changes, it's there in
> HEAD.

OK, but it seems to me that your version of my patch rearranges the
code more than necessary.

How about the attached?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Allow ATTACH PARTITION with only ShareUpdateExclusiveLock.
- 898e5e3290a7 12.0 landed
Change lock acquisition order in expand_inherited_rtentry.
- f4b6341d5fcb 12.0 landed
Move code for managing PartitionDescs into a new file, partdesc.c
- 1bb5e7821810 12.0 landed
Remove more redundant relation locking during executor startup.
- f2343653f5b2 12.0 cited
Add assertions that we hold some relevant lock during relation open.
- b04aeb0a053e 12.0 cited
Try to acquire relation locks in RangeVarGetRelid.
- 4240e429d0c2 9.2.0 cited