Horton

Re: Extending amcheck to check toast size and compression

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Greg Stark <stark@mit.edu>, Heikki Linnakangas <hlinnaka@iki.fi>, Aleksander Alekseev <aleksander@timescale.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-11-04T14:53:13Z
Lists: pgsql-hackers 
On Wed, Nov 3, 2021 at 6:56 PM Mark Dilger <mark.dilger@enterprisedb.com> wrote:
> Done that way.

I agree with what others have said: this looks fine.

But, is it plausible to add test coverage for the new checks, or is
that going to be too much of a pain?

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Remove tests added by bd807be6935929bdefe74d1258ca08048f0aafa3.

  2. amcheck: Add additional TOAST pointer checks.