Re: [v9.2] DROP statement reworks
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, Kohei KaiGai <kaigai@kaigai.gr.jp>, PgHacker <pgsql-hackers@postgresql.org>
Date: 2011-10-03T16:20:15Z
Lists: pgsql-hackers
On Mon, Oct 3, 2011 at 11:28 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Robert Haas <robertmhaas@gmail.com> writes: >> On Mon, Oct 3, 2011 at 10:54 AM, Dimitri Fontaine >> <dimitri@2ndquadrant.fr> wrote: >>> Robert Haas <robertmhaas@gmail.com> writes: >>>> I think that new versions of patch can handle unified diffs without a >>>> problem, but older versions choke on them. My Mac has 2.5.8 and >>>> handles unidiffs no problem. > >>> Even containing git headers? > >> Yeah, it just skips right over them. I've never had even a minor >> problem on that account, which is why I was surprised to see it giving >> you so much trouble. > > I haven't observed any such problems even with the rather ancient copy > of GNU patch on my HPUX box (seems to be 2.5.4, released in 1999). > I vaguely recall having had to replace the even older vendor-supplied > patch because that one didn't do unidiffs ... I have seen unified diffs blow up when using patch on a fairly new HP-UX box, but I'm not sure whether I'm using an OS-supplied copy of patch or something someone installed along the line somewhere. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company