Re: patch: move dumpUserConfig call in dumpRoles function of pg_dumpall.c
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Phil Sorber <phil@omniti.com>, pgsql-hackers@postgresql.org
Date: 2011-10-14T18:16:40Z
Lists: pgsql-hackers
On Wed, Oct 12, 2011 at 7:07 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Phil Sorber <phil@omniti.com> writes: >> Then there is a separate section of code that is called as a separate >> function 'dumpUserConfig()' that does other role attributes like >> 'ALTER ROLE bob SET role TO charlie'. These are the ALTER's that can >> have dependencies on other roles. > > Right. Phrased that way, this is an obvious improvement, and I concur > that it doesn't look like it could break anything that works now. > The more general problem remains to be solved, but we might as well > apply this. OK, done. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company