Re: Fix for gistchoose

On Thu, Aug 30, 2012 at 1:27 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Mon, Aug 20, 2012 at 12:57 PM, Alexander Korotkov
>> <aekorotkov@gmail.com> wrote:
>>> I found that code of gistchoose doesn't follow it's logic. Idea of
>>> gistchoose is that first column penalty is more important than penalty of
>>> second column. If we meet same penalty values of first column then we choose
>>> minimal penalty value of second column among them.
>
>> Nice catch.  Thanks for the patch, which I have now committed.
>
> Should we backpatch that?

Arguably, yes.  Does the patch look sane to you?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company