Horton

Re: Patch: Add --no-comments to skip COMMENTs with pg_dump

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>, Simon Riggs <simon@2ndquadrant.com>, Fabrízio Mello <fabriziomello@gmail.com>, Robins Tharakan <tharakan@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, David Fetter <david@fetter.org>, Tom Lane <tgl@sss.pgh.pa.us>, "David G. Johnston" <david.g.johnston@gmail.com>
Date: 2017-09-12T14:36:55Z
Lists: pgsql-hackers 
On Mon, Sep 11, 2017 at 6:41 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Mon, Sep 11, 2017 at 11:43 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> So I think this is just an excuse for turning --no-security-labels
>> into --no-object-property=security-label.  To me, that's just plain
>> worse.
>
> It does not seem that my thoughts here have been correctly transmitted
> to your brain.

Dang, we really should have put more work into that inter-brain link.
PostgreSQL group mind FTW!

> I do not mean to change the user-facing options, just
> to refactor the code internally so as --no-foo switches can be more
> easily generated, added and handled as they are associated with an
> object type. A portion of the complains is caused by the fact that a
> lot of similar code is duplicated.

Ah, well.  No objection to refactoring away duplicate code, of course.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Support --no-comments in pg_dump, pg_dumpall, pg_restore.

  2. Improve pg_dump's handling of "special" built-in objects.