Re: tableam vs. TOAST

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es

From: Robert Haas <robertmhaas@gmail.com>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2019-07-08T16:52:05Z

Lists: pgsql-hackers

Attachments

0004-Rename-attribute-detoasting-functions.patch (application/octet-stream) patch 0004
0003-Allow-TOAST-tables-to-be-implemented-using-table-AMs.patch (application/octet-stream) patch 0003
0002-Create-an-API-for-inserting-and-deleting-rows-in-TOA.patch (application/octet-stream) patch 0002
0001-Split-tuptoaster.c-into-three-separate-files.patch (application/octet-stream) patch 0001

On Sun, Jul 7, 2019 at 11:08 PM Thomas Munro <thomas.munro@gmail.com> wrote:
> Thus spake GCC:
>
> detoast.c: In function ‘toast_fetch_datum’:
> detoast.c:308:12: error: variable ‘toasttupDesc’ set but not used
> [-Werror=unused-but-set-variable]
> TupleDesc toasttupDesc;
> ^

Hmm, fixed, I hope.

Here's an updated patch set.  In addition to the above fix, I fixed
things up for the new pgindent rules and added a fourth patch that
renames the detoasting functions to something that doesn't include
'heap.'

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

tableam: New callback relation_fetch_toast_slice.
- ce242ae154dd 13.0 landed
tableam: Allow choice of toast AM.
- 83322e38da1a 13.0 landed
Move heap-specific detoasting logic into a separate function.
- e9fd0415e6e2 13.0 landed
Code cleanup for toast_fetch_datum and toast_fetch_datum_slice.
- d5406dea25b6 13.0 landed
Rename some toasting functions based on whether they are heap-specific.
- 2e8b6bfa90b2 13.0 landed
Create an API for inserting and deleting rows in TOAST tables.
- bd124996ef0d 13.0 landed
Split tuptoaster.c into three separate files.
- 8b94dab06617 13.0 landed
tableam: Move heap-specific logic from needs_toast_table below tableam.
- 1171d7d58545 12.0 cited