Horton

Re: tuplesort memory usage: grow_memtuples

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Peter Geoghegan <peter@2ndquadrant.com>
Cc: Greg Stark <stark@mit.edu>, Simon Riggs <simon@2ndquadrant.com>, Jeff Janes <jeff.janes@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2012-11-16T14:12:21Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Incorporate a couple of recent tuplesort.c improvements into tuplestore.c.

On Thu, Nov 15, 2012 at 4:13 PM, Peter Geoghegan <peter@2ndquadrant.com> wrote:
> On 15 November 2012 19:54, Greg Stark <stark@mit.edu> wrote:
>> The only concern I had was about the behaviour after it did the
>> special case. I didn't want it to keep doing the math and trying to
>> grow again a little bit every tuple. I think I was leaning to putting
>> the magic flag back.
>
> The alternative might just be to add a new constant to the
> TupSortStatus enum. That might be more logical.

That seems like a misfit to me, but throwing in "bool
cangrowmemtuples" or something like that seems like a good solution.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company