Horton
Menu

Re: [PATCH] binary heap implementation

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Abhijit Menon-Sen <ams@2ndquadrant.com>, pgsql-hackers@postgresql.org
Date: 2012-11-15T16:12:39Z
Lists: pgsql-hackers 
On Thu, Nov 15, 2012 at 10:21 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
>> Other than the coding style issues, I think this looks fine.  If you
>> can fix that up, I believe I could go ahead and commit this, unless
>> anyone else objects.
>
> Does this include the changes in nodeMergeappend.c?

I think so.  I was going to double-check the performance before
committing, but it doesn't look like there should be a problem.
Coding style changes appear needed in that file as well, however.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix memory leaks in record_out() and record_send().