Horton

Re: [PATCH] pageinspect function to decode infomasks

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Craig Ringer <craig@2ndquadrant.com>
Cc: Moon Insung <Moon_Insung_i3@lab.ntt.co.jp>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Julien Rouhaud <rjuju123@gmail.com>, Pavan Deolasee <pavan.deolasee@2ndquadrant.com>, Álvaro Herrera <alvherre@2ndquadrant.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Masahiko Sawada <sawada.mshk@gmail.com>, abhijit Menon-Sen <ams@2ndquadrant.com>, Peter Geoghegan <pg@bowt.ie>, Ashutosh Sharma <ashu.coek88@gmail.com>
Date: 2017-08-15T13:24:28Z
Lists: pgsql-hackers 
On Mon, Aug 14, 2017 at 9:59 PM, Craig Ringer <craig@2ndquadrant.com> wrote:
> The bits are set, those macros just test to exclude the special meaning of
> both bits being set at once to mean "frozen".
>
> I was reluctant to filter out  HEAP_XMIN_COMMITTED and HEAP_XMIN_INVALID
> when we detect that it's frozen, because that could well be misleading when
> debugging.

I don't think so -- the "committed" and "invalid" meanings are
effectively canceled when the "frozen" mask is present.

I mean, "committed" and "invalid" contradict each other...

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Redesign pageinspect function printing infomask bits

  2. Add to pageinspect function to make t_infomask/t_infomask2 human-readable

  3. Improve documentation of pageinspect

  4. Improve pageinspect module