something has gone wrong, but what is it?
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
Andres Freund <andres@anarazel.de>
Date: 2022-08-10T13:41:30Z
Lists: pgsql-hackers
Attachments
- v1-0001-Be-more-specific-about-exactly-what-has-gone-wron.patch (application/octet-stream) patch v1-0001
Hi, Today while hacking I encountered this delight: 2022-08-10 09:30:29.025 EDT [27126] FATAL: something has gone wrong I actually already knew that something had gone wrong, because the code I was writing was incomplete. And if I hadn't known that, the word FATAL would have been a real good clue. What I was hoping was that the error message might tell me WHAT had gone wrong, but it didn't. This seems to be the fault of Andres's commit 5aa4a9d2077fa902b4041245805082fec6be0648. In his defense, the addition of any kind of elog() at that point in the code appears to be an improvement over the previous state of affairs. Nonetheless I feel we could do better still, as in the attached. -- Robert Haas EDB: http://www.enterprisedb.com
Commits
-
Fix non-specific error message.
- 34dffa0224bd 16.0 landed
-
process startup: Separate out BootstrapModeMain from AuxiliaryProcessMain.
- 5aa4a9d2077f 15.0 cited