Re: Add missing PGDLLIMPORT markings
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter@eisentraut.org>,
pgsql-hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>,
Jacob Champion <jacob.champion@enterprisedb.com>, Heikki Linnakangas <heikki.linnakangas@iki.fi>,
Rahila Syed <rahilasyed90@gmail.com>
Date: 2025-04-10T16:03:00Z
Lists: pgsql-hackers
On Wed, Apr 9, 2025 at 1:10 PM Andres Freund <andres@anarazel.de> wrote: > I think eventually we ought to change the default visibility in the main binary to hidden, just like we do for extensions. Then the windows/everything else behavior difference vanishes and we actually get the benefit of being more restrictive on common platforms. I think we still ought to default to exporting symbols in such a world, just not always do so. We probably should just require all externs are either marked "server only" or "visible to extensions", never just a plain extern. The issue we're going to run into is that a lot of extension authors like to call things that the core developers probably think they shouldn't. If we lock it down, we'll either be breaking a bunch of extensions that are doing sneaky things that somebody has managed to make work ... or we're going to be committing to an API that we don't really want to support. To be clear, I'm not saying you're wrong, just that it's going to be hard to change anything without making somebody unhappy. -- Robert Haas EDB: http://www.enterprisedb.com
Commits
-
Add missing PGDLLIMPORT markings
- 7d430a57281f 18.0 landed
-
Rename global variable backing DSA area
- 55ef7abf88c0 18.0 landed