Re: pgsql: Implement pg_wal_replay_wait() stored procedure

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Heikki Linnakangas <hlinnaka@iki.fi>

Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Alexander Korotkov <aekorotkov@gmail.com>, Michael Paquier <michael@paquier.xyz>, Pavel Borisov <pashkin.elfe@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2024-11-04T16:53:20Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert pg_wal_replay_wait() stored procedure
- 3a7ae6b3d91e 18.0 landed
Add 'no_error' argument to pg_wal_replay_wait()
- e546989a269d 18.0 landed
Refactor WaitForLSNReplay() to return the result of waiting
- 73da6b8d1b3e 18.0 landed
Make WaitForLSNReplay() issue FATAL on postmaster death
- 6cfebfe88b9a 18.0 landed
Move LSN waiting declarations and definitions to better place
- 5035172e4ab5 18.0 landed
Update oid for pg_wal_replay_wait() procedure
- e658038772f5 18.0 landed
Move pg_wal_replay_wait() to xlogfuncs.c
- 014f9f34d252 18.0 landed
Implement pg_wal_replay_wait() stored procedure
- 3c5db1d6b016 18.0 cited

On Mon, Nov 4, 2024 at 10:57 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> > There's also the patch that Heikki posted to wait using a
> > protocol-level facility.
>
> It was Peter E

Oops.

> > Maybe that's just a better fit and we don't need either a procedure
> > or new syntax.
> I think it would still be good to expose the feature at SQL level too.
> Makes it easier to test and makes it usable without client library
> changes, for example.

OK. Well then I agree with Álvaro. If using a procedure isn't working
out nicely, it's better to consider alternatives than to force a round
peg into a square hole (with due regard for the fact that you can fit
anything through the square hole if you make the square hole big
enough...).

-- 
Robert Haas
EDB: http://www.enterprisedb.com