Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Remove stray word from pg_stash_advice docs.

  1. pg_stash_advice doc

    Erik Rijkers <er@xs4all.nl> — 2026-04-10T09:18:01Z

    Hi,

The pg_stash_advice doc ( doc/src/sgml/pgstashadvice.sgml ) contains 
this sentence:

"This means both that it is important to be mindful
of memory consumption when deciding how much plan advice to stash."

It seems to me 'both' should be 'also', or maybe just dropped.

Thanks,

Erik

  2. Re: pg_stash_advice doc

    Robert Haas <robertmhaas@gmail.com> — 2026-04-10T15:57:41Z

    On Fri, Apr 10, 2026 at 5:18 AM Erik Rijkers <er@xs4all.nl> wrote:
> "This means both that it is important to be mindful
> of memory consumption when deciding how much plan advice to stash."
>
> It seems to me 'both' should be 'also', or maybe just dropped.

Oops. That sentence had a second part in the first pg_stash_advice
commit, and the second commit remove the second part of the sentence
without remembering to delete the word "both".

-- 
Robert Haas
EDB: http://www.enterprisedb.com

  3. Re: pg_stash_advice doc

    Robert Haas <robertmhaas@gmail.com> — 2026-04-13T16:54:08Z

    On Fri, Apr 10, 2026 at 11:57 AM Robert Haas <robertmhaas@gmail.com> wrote:
> On Fri, Apr 10, 2026 at 5:18 AM Erik Rijkers <er@xs4all.nl> wrote:
> > "This means both that it is important to be mindful
> > of memory consumption when deciding how much plan advice to stash."
> >
> > It seems to me 'both' should be 'also', or maybe just dropped.
>
> Oops. That sentence had a second part in the first pg_stash_advice
> commit, and the second commit remove the second part of the sentence
> without remembering to delete the word "both".

I have committed a fix. Thanks again for the report.

-- 
Robert Haas
EDB: http://www.enterprisedb.com