Horton

Re: pg14 psql broke \d datname.nspname.relname

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Stephen Frost <sfrost@snowman.net>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Geoghegan <pg@bowt.ie>, Mark Dilger <mark.dilger@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2021-10-13T16:46:27Z
Lists: pgsql-hackers 
On Tue, Oct 12, 2021 at 12:57 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> I would prefer if it errored if the datname didn't match the current database.
> After all, it would've helped me to avoid making a confusing problem report.

How would you have felt if it had said something like:

error: argument to \d should be of the form
[schema-name-pattern.]relation-name-pattern

Would that have been better or worse for you than accepting a third
part of the pattern as a database name if and only if it matched the
current database name exactly?

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Remove some recently-added pg_dump test cases.

  2. Allow db.schema.table patterns, but complain about random garbage.

  3. Improve error handling of HMAC computations

  4. Factor pattern-construction logic out of processSQLNamePattern.