Horton
Menu

Re: pg_plan_advice

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Ajay Pal <ajay.pal.k@gmail.com>
Cc: Jakub Wartak <jakub.wartak@enterprisedb.com>, Lukas Fittl <lukas@fittl.com>, Jacob Champion <jacob.champion@enterprisedb.com>, Dian Fay <di@nmfay.com>, Matheus Alcantara <matheusssilv97@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-21T19:26:02Z
Lists: pgsql-hackers

Attachments

On Wed, Jan 21, 2026 at 6:52 AM Ajay Pal <ajay.pal.k@gmail.com> wrote:
> Subsequent testing revealed that UNION operations involving constants
> which enforce empty subplans result in the generated partition-wise
> plan not being recognized by the planner.

Good catch, thank you. Should be fixed in this version.

Changes in v11:

- What was previously 0004 has been promoted to 0001. This is the
pgs_mask stuff to allow extensions to control the planner more easily,
which seems separately committable based on reviews to this point.
- Fixed a bug found by Jacob wherein GATHER() and some other tags
permitted multiple levels of nested sublists instead of, as intended,
only a single one.
- Added a test for that case, too.
- Fixed JOIN_ORDER(justonerel) so that it correctly reports "matched"
instead of incorrectly reporting "partially matched" even when
justonerel was part of a join problem.
- Add tests for specifying a prefix of the join order list.
- Removed an XXX comment from the join order tests that now seems bogus to me.
- Fixed a bug in pg_plan_advice_explain_text_multiline that caused it
to display nothing in text format when the label was empty, instead of
when the value was empty.
- Add COSTS OFF to various tests in syntax.sql. I initially omitted
this because I thought it wouldn't be necessary, but I should know
better.
- Add a test for EXPLAIN (PLAN_ADVICE) in non-text format.
- Add tests for SEMIJOIN_UNIQUE() and SEMIJOIN_NON_UNIQUE().
- Rewrite a bunch of buggy logic related to SEMIJOIN_UNIQUE() and
SEMIJOIN_NON_UNIQUE().
- Show the join type in pg_plan_advice.trace_mask output.
- Per this email from Ajay, apply the unique_nonjoin_rtekind() test to
elided (Merge)Append nodes as we do to non-elided ones.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_plan_advice: Fix another unique-semijoin bug.

  2. pg_plan_advice: Export feedback-related definitions.

  3. pg_plan_advice: Fix a bug when a subquery is pruned away entirely.

  4. pg_plan_advice: Add alternatives test to Makefile.

  5. pg_plan_advice: Handle non-repeatable TABLESAMPLE scans.

  6. pg_stash_advice: Allow stashed advice to be persisted to disk.

  7. Add pg_stash_advice contrib module.

  8. pg_plan_advice: Avoid assertion failure with partitionwise aggregate.

  9. pg_plan_advice: Invent DO_NOT_SCAN(relation_identifier).

  10. Add an alternative_plan_name field to PlannerInfo.

  11. pg_plan_advice: Refactor to invent pgpa_planner_info

  12. Respect disabled_nodes in fix_alternative_subplan.

  13. get_memoize_path: Don't exit quickly when PGS_NESTLOOP_PLAIN is unset.

  14. test_plan_advice: Set TAP test priority 50 in meson.build.

  15. pg_plan_advice: Avoid a crash under GEQO.

  16. Test pg_plan_advice using a new test_plan_advice module.

  17. pg_plan_advice: Always install pg_plan_advice.h, and in the right place

  18. pg_plan_advice: Fix failures to accept identifier keywords.

  19. Add pg_plan_advice contrib module.

  20. Allow extensions to mark an individual index as disabled.

  21. Replace get_relation_info_hook with build_simple_rel_hook.

  22. Store information about Append node consolidation in the final plan.

  23. Store information about elided nodes in the final plan.

  24. Store information about range-table flattening in the final plan.

  25. Pass cursorOptions to planner_setup_hook.

  26. Fix PGS_CONSIDER_NONPARTIAL interaction with Materialize nodes.

  27. Fix mistakes in commit 4020b370f214315b8c10430301898ac21658143f

  28. Allow for plugin control over path generation strategies.

  29. Update some comments for fasthash

  30. Allow passing a pointer to GetNamedDSMSegment()'s init callback.

  31. Don't reset the pathlist of partitioned joinrels.

  32. Treat number of disabled nodes in a path as a separate cost metric.