Horton
Menu

Re: pg_plan_advice

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Alexandra Wang <alexandra.wang.oss@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>, Lukas Fittl <lukas@fittl.com>, Tom Lane <tgl@sss.pgh.pa.us>, Jacob Champion <jacob.champion@enterprisedb.com>, Dian Fay <di@nmfay.com>, Matheus Alcantara <matheusssilv97@gmail.com>, Jakub Wartak <jakub.wartak@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-02-10T23:03:34Z
Lists: pgsql-hackers

Attachments

On Mon, Feb 9, 2026 at 10:55 AM Alexandra Wang
<alexandra.wang.oss@gmail.com> wrote:
> On Sat, Feb 7, 2026 at 9:38 AM Robert Haas <robertmhaas@gmail.com> wrote:
> > Here is a new patch set (v14).
>
> Thanks for the patches! 0003 - 0005 look good to me.

I have committed those, as well as 0001 and 0002. Here's v15. The main
patch is now 0002, and has the following changes since the last
version:

- Added a new GUC pg_plan_advice.feedback_warnings, disabled by
default, which can be set to true to produce a warning about plan
advice strings that aren't fully working. (Previously, you had to use
EXPLAIN to get this information.)

- Use get_namespace_name_or_temp, rather than get_name_namespace,
consistently. One use of the latter function crept in, breaking
INDEX_SCAN and INDEX_ONLY_SCAN advice for temporary tables.

- Fix a problem in pgpa_scan.c that could cause spurious NO_GATHER
advice to be generated in certain situations, such as when joins were
proven empty.

- Fix a logic error in the handling of JOIN_ORDER advice that could
cause it to be marked as conflicting with PARTITIONWISE advice when
that was not in reality the case.

- Incorporate documentation corrections from David G. Johnston. I
didn't take all of his suggestions, but I took many of them, sometimes
with some additional wordsmithing on my part.

- Remove a stray comment.

Also a reminder that 0003 and 0004 (previously 0008 and 0009) don't
properly belong to this thread, but I've included them here because
otherwise the tests in the last patch don't pass. See
http://postgr.es/m/CA+TgmobRufbUSksBoxytGJS1P+mQY4rWctCk-d0iAUO6-k9Wrg@mail.gmail.com
for discussion of those patches.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_plan_advice: Fix another unique-semijoin bug.

  2. pg_plan_advice: Export feedback-related definitions.

  3. pg_plan_advice: Fix a bug when a subquery is pruned away entirely.

  4. pg_plan_advice: Add alternatives test to Makefile.

  5. pg_plan_advice: Handle non-repeatable TABLESAMPLE scans.

  6. pg_stash_advice: Allow stashed advice to be persisted to disk.

  7. Add pg_stash_advice contrib module.

  8. pg_plan_advice: Avoid assertion failure with partitionwise aggregate.

  9. pg_plan_advice: Invent DO_NOT_SCAN(relation_identifier).

  10. Add an alternative_plan_name field to PlannerInfo.

  11. pg_plan_advice: Refactor to invent pgpa_planner_info

  12. Respect disabled_nodes in fix_alternative_subplan.

  13. get_memoize_path: Don't exit quickly when PGS_NESTLOOP_PLAIN is unset.

  14. test_plan_advice: Set TAP test priority 50 in meson.build.

  15. pg_plan_advice: Avoid a crash under GEQO.

  16. Test pg_plan_advice using a new test_plan_advice module.

  17. pg_plan_advice: Always install pg_plan_advice.h, and in the right place

  18. pg_plan_advice: Fix failures to accept identifier keywords.

  19. Add pg_plan_advice contrib module.

  20. Allow extensions to mark an individual index as disabled.

  21. Replace get_relation_info_hook with build_simple_rel_hook.

  22. Store information about Append node consolidation in the final plan.

  23. Store information about elided nodes in the final plan.

  24. Store information about range-table flattening in the final plan.

  25. Pass cursorOptions to planner_setup_hook.

  26. Fix PGS_CONSIDER_NONPARTIAL interaction with Materialize nodes.

  27. Fix mistakes in commit 4020b370f214315b8c10430301898ac21658143f

  28. Allow for plugin control over path generation strategies.

  29. Update some comments for fasthash

  30. Allow passing a pointer to GetNamedDSMSegment()'s init callback.

  31. Don't reset the pathlist of partitioned joinrels.

  32. Treat number of disabled nodes in a path as a separate cost metric.