Horton

Re: pgsql: Provide overflow safe integer math inline functions.

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Christoph Berg <myon@debian.org>, Andres Freund <andres@anarazel.de>, pgsql-committers <pgsql-committers@postgresql.org>
Date: 2017-12-13T14:37:25Z
Lists: pgsql-hackers 
On Wed, Dec 13, 2017 at 5:10 AM, Christoph Berg <myon@debian.org> wrote:
> Re: Andres Freund 2017-12-13 <E1eOvQF-00075r-Cy@gemulon.postgresql.org>
>> Provide overflow safe integer math inline functions.
>
> The new _overflow functions have buggy comments:
>
> /*
>  * If a - b overflows, return true, otherwise store the result of a + b into
>  * *result.                                                         ^ there

What's wrong with that?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Try harder to detect unavailability of __builtin_mul_overflow(int64).

  2. Try to detect runtime unavailability of __builtin_mul_overflow(int64).

  3. Fix a number of copy & paste comment errors in common/int.h.

  4. Provide overflow safe integer math inline functions.