Re: [v9.2] DROP statement reworks
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Kohei KaiGai <kaigai@kaigai.gr.jp>
Cc: Dimitri Fontaine <dimitri@2ndquadrant.fr>, PgHacker <pgsql-hackers@postgresql.org>
Date: 2011-10-20T03:33:47Z
Lists: pgsql-hackers
On Wed, Oct 19, 2011 at 3:30 PM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote: > part-1: only regression test of DROP [IF EXISTS] on unmodified master Committed. Which I just noticed broke the build farm. Will go fix that now... > part-2: drop statement reworks that uses T_DropStmt Committed with some changes. > part-3: drop statement reworks for other object classes This is going to need some rebasing. > Unfortunately, the part-3 had to change regression test portion a bit, > because ... > - Unmodified master does not print ", skipping" when we tried to > drop non-existence operator class with IF EXISTS. OK, we should fix that. > - Unmodified master raised an error, not notice, when we tried to > drop non-existence operator family with IF EXISTS. > Is it a bug to be fixed, isn't it? Yeah, that seems like a bug. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company