Horton

Re: post-freeze damage control

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2024-04-22T19:19:15Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. revert: Transform OR clauses to ANY expression

  2. Fix incorrect calculation in BlockRefTableEntryGetBlocks.

On Tue, Apr 16, 2024 at 7:20 PM Jeff Davis <pgsql@j-davis.com> wrote:
> We maintain the invariant:
>
>    XLogCtl->logFlushResult <= XLogCtl->logWriteResult
>
> and the non-shared version:
>
>    LogwrtResult.Flush <= LogwrtResult.Write
>
> and that the requests don't fall behind the results:

I had missed the fact that this commit added a bunch of read and write
barriers; and I think that's the main reason why I was concerned. The
existence of those barriers, and the invariants they are intended to
maintain, makes me feel better about it.

Thanks for writing back about this!

-- 
Robert Haas
EDB: http://www.enterprisedb.com