Re: basebackup.c's sendFile() ignores read errors

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Jeevan Chalke <jeevan.chalke@enterprisedb.com>

Cc: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2019-09-06T13:18:03Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

When performing a base backup, check for read errors.
- fbe897134801 9.4.25 landed
- f697c6396d73 9.5.20 landed
- 23df8822601d 9.6.16 landed
- 62fb12d7e138 10.11 landed
- 61c65cce40e6 11.6 landed
- ce5542d40253 12.0 landed
- 286af0ce1211 13.0 landed

On Fri, Sep 6, 2019 at 2:08 AM Jeevan Chalke
<jeevan.chalke@enterprisedb.com> wrote:
> Attached patch for v10 and pre. The same v10 patch applies cleanly.
>
> Changes related to the page checksum verification is not present on v10 and
> pre, and thus those changes are not applicable, so removed those.  Also,
> wal_segment_size is XLogSegSize over there, adjusted that.

Thanks.  Committed the v3 patch to v11+ and this version to the older branches.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company