Horton

Re: pg_combinebackup fails on file named INCREMENTAL.*

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: David Steele <david@pgmasters.net>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>, Tomas Vondra <tomas.vondra@enterprisedb.com>
Date: 2024-04-18T15:10:08Z
Lists: pgsql-hackers 
On Wed, Apr 17, 2024 at 7:56 PM David Steele <david@pgmasters.net> wrote:
> Thanks! I've tested this and it works as advertised.
>
> Ideally I'd want an error on backup if there is a similar file in any
> data directories that would cause an error on combine, but I admit that
> it is vanishingly rare for users to put files anywhere but the root of
> PGDATA, so this approach seems OK to me.

OK, committed. Thanks for the review.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Restrict where INCREMENTAL.${NAME} files are recognized.