Horton

Re: [PATCH] PostgreSQL fails to build with 32bit MinGW-w64

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, Mark Cave-Ayland <mark.cave-ayland@siriusit.co.uk>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-12-14T17:59:53Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove troublesome Asserts in cost_mergejoin().

  2. Enable building with the Mingw64 compiler.

On Wed, Dec 14, 2011 at 12:36 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> AFAICS it's really impractical to do that.  The code Andrew is having
> problems with is essentially
>
>        double a,b,c;
>        ...
>        a = b * c;
>        if (isinf(a)) throw error;
>
> and the problem is that the multiplication result overflows in double
> precision, but not in the wider-than-double register precision.
> Therefore, if a is in a register and the isinf() primitive inspects the
> register, it will return false, even though when the value gets stored
> to memory it will become an infinity.

Uh, wow.  That really is pretty insane.  How is anyone supposed to
write sensible code around that non-API?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company