Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-01-17T17:58:38Z
Lists: pgsql-hackers
On Tue, Jan 17, 2017 at 12:52 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Robert Haas <robertmhaas@gmail.com> writes: >> On Mon, Jan 16, 2017 at 2:13 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> "Srf" is ugly as can be, and unintelligible. SetResult might be OK. > >> The operation we're performing here, IIUC, is projection. SetResult >> lacks a verb, although Set could be confused with one; someone might >> think this is the node that sets a result, whatever that means. >> Anyway, I suggest working Project in there somehow. If Project by >> itself seems like it's too generic, perhaps ProjectSet or >> ProjectSetResult would be suitable. > > Andres' patch is already using "SetProjectionPath" for the path struct > type. Maybe make that "ProjectSetPath", giving rise to a "ProjectSet" > plan node? +1. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Remove obsoleted code relating to targetlist SRF evaluation.
- ea15e18677fc 10.0 landed
-
Doc: improve documentation of new SRF-in-tlist behavior.
- f13a1277aa2d 10.0 landed
-
Move targetlist SRF handling from expression evaluation to new executor node.
- 69f4b9c85f16 10.0 landed
-
Don't split up SRFs when choosing to postpone SELECT output expressions.
- d543170f2fdd 9.6.0 cited