Horton

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Fabrízio Mello <fabriziomello@gmail.com>
Cc: Robins Tharakan <tharakan@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, David Fetter <david@fetter.org>, Tom Lane <tgl@sss.pgh.pa.us>, "David G. Johnston" <david.g.johnston@gmail.com>, Stephen Frost <sfrost@snowman.net>, Michael Paquier <michael.paquier@gmail.com>
Date: 2017-11-28T20:50:13Z
Lists: pgsql-hackers 
On Mon, Aug 7, 2017 at 11:14 AM, Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
> I also test against all current supported versions (9.2 ... 9.6) and didn't
> find any issue.
>
> Changed status to "ready for commiter".

On a very fast read this patch looks OK to me, but I'm a bit concerned
about whether we have consensus for it.  By my count the vote is 6-3
in favor of proceeding.

+1: Robins Tharakan, Stephen Frost, David Fetter, Fabrizio Mello,
Michael Paquier, Robert Haas
-1: David G. Johnston, Tom Lane, Simon Riggs

I guess that's probably sufficient to go forward, but does anyone wish
to dispute my characterization of their vote or the vote tally in
general?  Would anyone else like to cast a vote?

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Support --no-comments in pg_dump, pg_dumpall, pg_restore.

  2. Improve pg_dump's handling of "special" built-in objects.