Horton

Re: HOT chain validation in verify_heapam()

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Himanshu Upadhyaya <upadhyaya.himanshu@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Aleksander Alekseev <aleksander@timescale.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2022-11-17T13:36:33Z
Lists: pgsql-hackers 
On Wed, Nov 16, 2022 at 10:57 PM Himanshu Upadhyaya
<upadhyaya.himanshu@gmail.com> wrote:
> I think if pred_xmin is aborted and curr_xmin is in progress we should consider it as a corruption case but vice versa is not true.

Yeah, you're right. I'm being stupid about subtransactions again.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. amcheck: Generalize one of the recently-added update chain checks.

  2. amcheck: Tighten up validation of redirect line pointers.

  3. amcheck: Fix verify_heapam for tuples where xmin or xmax is 0.

  4. amcheck: Fix a few bugs in new update chain validation.

  5. Fix new test case to work on (some?) big-endian architectures.

  6. Don't test HEAP_XMAX_INVALID when freezing xmax.