Re: tablespace_map code cleanup

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2020-05-06T15:15:57Z

Lists: pgsql-hackers

Attachments

v2-0001-Don-t-export-basebackup.c-s-sendTablespace.patch (application/octet-stream) patch v2-0001
v2-0002-Minor-code-cleanup-for-perform_base_backup.patch (application/octet-stream) patch v2-0002

On Mon, May 4, 2020 at 5:24 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> If we want to move the calculation of size for tablespaces in the
> caller then I think we also need to do something about the progress
> reporting related to phase
> PROGRESS_BASEBACKUP_PHASE_ESTIMATE_BACKUP_SIZE.

Oh, good point. v2 attached.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Minor code cleanup for perform_base_backup().
- 453e0e3f0ef3 14.0 landed
Don't export basebackup.c's sendTablespace().
- 1fa092913d26 14.0 landed
Map basebackup tablespaces using a tablespace_map file
- 72d422a5227e 9.5.0 cited