Re: in-catalog Extension Scripts and Control parameters (templates?)

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Alvaro Herrera <alvherre@2ndquadrant.com>

Cc: Heikki Linnakangas <hlinnakangas@vmware.com>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, Stephen Frost <sfrost@snowman.net>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2013-03-28T11:38:55Z

Lists: pgsql-hackers

On Wed, Mar 27, 2013 at 10:32 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
>> Surely creating an extension template must be a superuser-only
>> operation, in which case this is an issue because Mallory could also
>> have just blown up the world directly if he's already a superuser
>> anyway.
>
> Yeah .. (except "this is NOT an issue")
>
>> If the current patch isn't enforcing that, it's 100% broken.
>
> Even if it's not enforcing that, it's not 100% broken, it only contains
> one more bug we need to fix.

Sure.  I didn't mean that such a mistake would make the patch
unsalvageable, only that it would be disastrous from a security point
of view.  But as you say, pretty easy to fix.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company