Horton

Re: RecoveryInProgress() has critical side effects

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: "Bossart, Nathan" <bossartn@amazon.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, amul sul <sulamul@gmail.com>
Date: 2021-11-16T20:19:19Z
Lists: pgsql-hackers 
On Tue, Nov 16, 2021 at 2:27 PM Andres Freund <andres@anarazel.de> wrote:
> Is this with assertions enabled? Because on my workstation (which likely is
> slower on a single-core basis than your laptop) I get around half of this with
> an optimized build (and a non-optimized build rarely is worth using as a
> measuring stick). It could also be that your psqlrc does something
> heavyweight?

Assertions disabled. ~/.psqlrc does not exist.

> Hm. I think this might included a bunch of convoluting factors that make it
> hard to judge the actual size of the performance difference.

Yes, I think so, too.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Remove InitXLOGAccess().

  2. Move InitXLogInsert() call from InitXLOGAccess() to BaseInit().