Horton

Re: pgsql: Clarify use of temporary tables within partition trees

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-committers@lists.postgresql.org
Date: 2018-07-03T01:07:58Z
Lists: pgsql-hackers 
On Mon, Jul 2, 2018 at 8:59 PM, David Rowley
<david.rowley@2ndquadrant.com> wrote:
>> How would you formulate it?  Perhaps the error message did not emphasize
>> enough on the fast that it actually blocked a behavior, say "Block mix
>> of temporary and permanent relations in partition trees" or such?

Yes.

> For me, reading the subject line of the commit I'd have expected a doc
> change, or improved/new code comments.
>
> This is really more "Disallow mixed temp/permanent partitioned hierarchies".

Yes.

> "Clarify" does not really involve a change of behaviour. It's an
> explanation of what the behaviour is.

And yes.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Remove dead code for temporary relations in partition planning

  2. Clarify use of temporary tables within partition trees

  3. Expand partitioned table RTEs level by level, without flattening.