Horton

Re: Showing primitive index scan count in EXPLAIN ANALYZE (for skip scan and SAOP scans)

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-08-28T13:35:33Z
Lists: pgsql-hackers 
On Tue, Aug 27, 2024 at 7:22 PM Matthias van de Meent
<boekewurm+postgres@gmail.com> wrote:
> > Besides, I thought that you wanted me to use some new field in
> > BTScanOpaque? But now you want me to use a global counter. Which is
> > it?
>
> If you think it's important to have this info on all indexes then I'd
> prefer the pgstat approach over adding a field in IndexScanDescData.
> If instead you think that this is primarily important to expose for
> nbtree index scans, then I'd prefer putting it in the BTSO using e.g.
> the index AM analyze hook approach, as I think that's much more
> elegant than this.

I agree with this analysis. I don't see why IndexScanDesc would ever
be the right place for this.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Show index search count in EXPLAIN ANALYZE, take 2.

  2. Show index search count in EXPLAIN ANALYZE.

  3. Allow usage of match_orclause_to_indexcol() for joins

  4. Fix nbtree pgstats accounting with parallel scans.

  5. Enhance nbtree ScalarArrayOp execution.

  6. Fix EXPLAIN ANALYZE of hash join when the leader doesn't participate.