Horton

Re: something has gone wrong, but what is it?

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Andres Freund <andres@anarazel.de>
Date: 2022-08-10T18:50:30Z
Lists: pgsql-hackers 
On Wed, Aug 10, 2022 at 2:06 PM Andrey Borodin <x4mmm@yandex-team.ru> wrote:
> > On 10 Aug 2022, at 19:49, Robert Haas <robertmhaas@gmail.com> wrote:
> > After a bit of further looking around I noticed that there's another
> > check for an invalid auxtype in this function which uses a slightly
> > different message text and also PANIC rather than ERROR.
>
> Is there a reason to do
> MyBackendType = B_INVALID;
> after PANIC or ERROR?

That could probably be taken out, but it doesn't seem important to take it out.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Fix non-specific error message.

  2. process startup: Separate out BootstrapModeMain from AuxiliaryProcessMain.