Re: Error message inconsistency
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>, MBeena Emerson <mbeena.emerson@gmail.com>, Simon Riggs <simon@2ndquadrant.com>, Fabrízio Mello <fabriziomello@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-01-27T15:54:19Z
Lists: pgsql-hackers
On Fri, Jan 24, 2020 at 12:22 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > One thing to note is that there are places in code where we use > 'table' instead of 'relation' for the same thing in the error messages > as seen in the below places (the first one uses 'relation', the second > one uses 'table') and the patch is using 'relation' which I think is > fine. We often use "relation" as a sort of a weasel-word when we don't know the relkind; i.e. when we're complaining about something that might be a view or index or foreign table or whatever. If we say "table," we need to know that it is, precisely, a table. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Added relation name in error messages for constraint checks.
- 05f18c6b6b6e 13.0 landed