Re: contrib modules and relkind check
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
Stephen Frost <sfrost@snowman.net>, Corey Huinker <corey.huinker@gmail.com>,
Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-03-10T02:03:15Z
Lists: pgsql-hackers
On Thu, Mar 9, 2017 at 7:23 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > Thanks. Shouldn't this fix be back-patched? pg_visibility should fail > properly for indexes and other relkinds even in 9.6. pgstattuple can > also trigger failures. It would be confusing for users to face "could > not open file" kind of errors instead of a proper error message. Note > that I am fine to produce those patches if there is a resource issue > for any of you two. I don't see a real need to back-patch this. I mean, it probably wouldn't break anything, but it feels more like we're raising our standards than fixing bugs per se. I don't think it benefits us when users see the release notes for a new minor release series cluttered with essentially non-critical fixes. It makes people worry about whether upgrading is safe. You might brand those people as silly, but they (indirectly) pay my mortgage. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Add relkind checks to certain contrib modules
- c08d82f38ebf 10.0 landed