Re: Network failure may prevent promotion

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: hlinnaka@iki.fi, masao.fujii@gmail.com, andres@anarazel.de, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
Date: 2024-05-14T14:16:00Z
Lists: pgsql-hackers
On Mon, Jan 29, 2024 at 2:32 AM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
> [ new patch set ]

Hi,

I think it would be helpful to make it more clear exactly what's going
on here. It looks 0001 is intended to revert
21ef4d4d897563adb2f7920ad53b734950f1e0a4, which was itself a revert of
728f86fec65537eade8d9e751961782ddb527934, and then I guess the
remaining patches are to fix up issues created by that commit, but the
commit messages aren't meaningful so it's hard to understand what is
being fixed.

I think it would also be useful to clarify whether this is imagined to
be for master only, or something to be back-patched. In addition to
mentioning that here, it would be good to add that information to the
target version field of  https://commitfest.postgresql.org/48/4748/

-- 
Robert Haas
EDB: http://www.enterprisedb.com



Commits

  1. Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h"

  2. libpqwalreceiver: Convert to libpq-be-fe-helpers.h