Horton

Re: Event Triggers reduced, v1

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Dimitri Fontaine <dimitri@2ndquadrant.fr>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2012-07-02T17:57:03Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Replace int2/int4 in C code with int16/int32

On Mon, Jul 2, 2012 at 1:56 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Fri, Jun 29, 2012 at 5:38 PM, Dimitri Fontaine
> <dimitri@2ndquadrant.fr> wrote:
>> Will do a whole warning check pass later. Can you give me your local
>> Makefile trick to turn them into hard errors again please? :)
>
> echo COPT=-Werror > src/Makefile.custom
>
> Your latest patch contains a warning about using a variable
> uninitialized that seems to indicate that you didn't test this very
> carefully: in get_event_triggers, current_any_name is set but not
> used.

Make that used but not set.  Anyhow, it's broken.  :-(

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company