Re: Modernizing our GUC infrastructure
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pavel Stehule <pavel.stehule@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-09-06T12:21:50Z
Lists: pgsql-hackers
On Tue, Sep 6, 2022 at 1:43 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: > I think there's a good analogy here to temporary tables. The SQL > spec says that temp-table schemas are persistent and database-wide, > but what we actually have is that they are session-local. People > occasionally propose that we implement the SQL semantics for that, > but in the last twenty-plus years no one has bothered to write a > committable patch to support it ... much less remove the existing > behavior in favor of that, which I'm pretty sure no one would think > is a good idea. Well, I've thought about doing this a few times, but it's a real pain in the neck, primarily because we store metadata that needs to be per-instantiation in the catalog rows: relfrozenxid, relminmxid, and the relation statistics. So I'm not sure "no one has bothered" is quite the right way to characterize it. "no one has been able to adequately untangle the mess" might be more accurate. > So, is it actually a good idea to have persistent metadata for > session variables? I'd say that the issue is at best debatable, > and at worst proven wrong by a couple of decades of experience. > In what way are session variables less mutable than temp tables? I haven't looked at that patch at all, but I would assume that variables would have SQL types, and that we would never add GUCs with SQL types, which seems like a pretty major semantic difference. -- Robert Haas EDB: http://www.enterprisedb.com
Commits
-
Add auxiliary lists to GUC data structures for better performance.
- f13b2088fa2d 16.0 landed
-
Replace the sorted array of GUC variables with a hash table.
- 3057465acfbe 16.0 landed
-
Store GUC data in a memory context, instead of using malloc().
- 407b50f2d421 16.0 landed
-
Make some minor improvements in memory-context infrastructure.
- 9c911ec065df 16.0 landed