Re: Patch: add timing of buffer I/O requests

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Ants Aasma <ants@cybertec.at>, Greg Smith <greg@2ndquadrant.com>, pgsql-hackers@postgresql.org

Date: 2012-04-10T17:51:15Z

Lists: pgsql-hackers

On Tue, Apr 10, 2012 at 1:44 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Tue, Apr 10, 2012 at 12:11 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Well, FWIW I vote for making the new columns be float8 msec.
>
>> Ugh.  So the three ways of doing timing that we have already aren't
>> enough, and we need a fourth one?  Ack!
>
> Huh?  I understood what you said upthread to be that we have two ways
> in existing releases (anything unreleased has zero standing in this
> discussion): float8 sec in pg_stat_statements.total_time, and
> int8 msec everywhere else.  Did I miss something?

We also have int8 usec floating around.  But even if we didn't, float8
msec would be a new one, regardless of whether it would be third or
fourth...

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company