Thread

  1. Warning in views.c

    Magnus Hagander <magnus@hagander.net> — 2012-01-16T20:47:49Z

    Seem 1575fbcb caused this warning:
    
    view.c: In function ‘DefineVirtualRelation’:
    view.c:105:6: warning: variable ‘namespaceId’ set but not used
    [-Wunused-but-set-variable]
    
    Attached seems to be the easy fix - or am I missing something obvious?
    
    -- 
     Magnus Hagander
     Me: http://www.hagander.net/
     Work: http://www.redpill-linpro.com/
    
  2. Re: Warning in views.c

    Robert Haas <robertmhaas@gmail.com> — 2012-01-19T20:43:18Z

    On Mon, Jan 16, 2012 at 3:47 PM, Magnus Hagander <magnus@hagander.net> wrote:
    > Seem 1575fbcb caused this warning:
    >
    > view.c: In function ‘DefineVirtualRelation’:
    > view.c:105:6: warning: variable ‘namespaceId’ set but not used
    > [-Wunused-but-set-variable]
    >
    > Attached seems to be the easy fix - or am I missing something obvious?
    
    No, I think you nailed it.  There is some more refactoring that should
    be done there, I think, but until it is, we don't need that return
    value for anything...
    
    Thanks for fixing it.
    
    -- 
    Robert Haas
    EnterpriseDB: http://www.enterprisedb.com
    The Enterprise PostgreSQL Company