Re: Showing primitive index scan count in EXPLAIN ANALYZE (for skip scan and SAOP scans)
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-08-28T13:49:08Z
Lists: pgsql-hackers
On Wed, Aug 28, 2024 at 9:41 AM Peter Geoghegan <pg@bowt.ie> wrote: > On Wed, Aug 28, 2024 at 9:35 AM Robert Haas <robertmhaas@gmail.com> wrote: > > > If you think it's important to have this info on all indexes then I'd > > > prefer the pgstat approach over adding a field in IndexScanDescData. > > > If instead you think that this is primarily important to expose for > > > nbtree index scans, then I'd prefer putting it in the BTSO using e.g. > > > the index AM analyze hook approach, as I think that's much more > > > elegant than this. > > > > I agree with this analysis. I don't see why IndexScanDesc would ever > > be the right place for this. > > Then what do you think is the right place? The paragraph that I agreed with and quoted in my reply, and that you then quoted in your reply to me, appears to me to address that exact question. -- Robert Haas EDB: http://www.enterprisedb.com
Commits
-
Show index search count in EXPLAIN ANALYZE, take 2.
- 0fbceae841cb 18.0 landed
-
Show index search count in EXPLAIN ANALYZE.
- 5ead85fbc811 18.0 landed
-
Allow usage of match_orclause_to_indexcol() for joins
- 627d63419e22 18.0 cited
-
Fix nbtree pgstats accounting with parallel scans.
- c00c54a9ac1e 18.0 landed
- fb4f5e58af97 17.0 landed
-
Enhance nbtree ScalarArrayOp execution.
- 5bf748b86bc6 17.0 cited
-
Fix EXPLAIN ANALYZE of hash join when the leader doesn't participate.
- 5bcf389ecfd4 11.0 cited