Horton
Menu

Re: pgsql: Add function to get memory context stats for processes

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Daniel Gustafsson <dgustafsson@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Rahila Syed <rahilasyed90@gmail.com>
Date: 2025-04-17T14:42:45Z
Lists: pgsql-hackers 
On Tue, Apr 15, 2025 at 6:11 AM Andres Freund <andres@anarazel.de> wrote:
> There very well could be a CFI - but it better be somewhere where the
> in-memory state is consistent. Otherwise an error inside raised in the CFI
> would lead the in-memory state inconsistent which then would cause problems
> when cleaning up the dsa during resowner release or process exit.
>
> What am I missing here?

I think maybe you're only thinking about gathering the data. What
about publishing it? If the DSA code were interrupted at a CFI and the
interrupting code went and tried to perform a DSA allocation to store
the resulting data and then returned to the interrupted DSA operation,
would you expect the code to cope with that? I do not believe we have
anywhere enough guarantees about reentrancy for that to be safe.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Rename global variable backing DSA area

  2. Add function to get memory context stats for processes