Horton

Re: making relfilenodes 56 bits

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Heikki Linnakangas <hlinnaka@iki.fi>, Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-07-05T21:02:37Z
Lists: pgsql-hackers 
On Tue, Jul 5, 2022 at 4:33 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> I thought about this comment from Robert
> > that's not quite the same as either of those things. For example, in
> > tableam.h we currently say "This callback needs to create a new
> > relation filenode for `rel`" and how should that be changed in this
> > new naming? We're not creating a new RelFileNumber - those would need
> > to be allocated, not created, as all the numbers in the universe exist
> > already. Neither are we creating a new locator; that sounds like it
> > means assembling it from pieces.
>
> I think that "This callback needs to create a new relation storage
> for `rel`" looks better.

I like the idea, but it would sound better to say "create new relation
storage" rather than "create a new relation storage."

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Fix typos in comments, code and documentation

  2. Increase width of RelFileNumbers from 32 bits to 56 bits.

  3. Move RelFileNumber declarations to common/relpath.h.

  4. Include RelFileLocator fields individually in BufferTag.

  5. Convert macros to static inline functions (buf_internals.h)

  6. Remove the restriction that the relmap must be 512 bytes.

  7. Change internal RelFileNode references to RelFileNumber or RelFileLocator.

  8. Reorder subskiplsn in pg_subscription to avoid alignment issues.

  9. Fix DROP {DATABASE,TABLESPACE} on Windows.

  10. Restructure smgr API as per recent proposal. smgr no longer depends on