Horton

Re: [v9.2] Fix Leaky View Problem

Robert Haas <robertmhaas@gmail.com>

View thread
From: Robert Haas <robertmhaas@gmail.com>
To: Kohei KaiGai <kaigai@kaigai.gr.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>, Kevin Grittner <Kevin.Grittner@wicourts.gov>, Kohei.Kaigai@emea.nec.com, thom@linux.com, pgsql-hackers@postgresql.org
Date: 2012-01-18T03:08:35Z
Lists: pgsql-hackers 
On Sun, Jan 8, 2012 at 10:32 AM, Kohei KaiGai <kaigai@kaigai.gr.jp> wrote:
>>> I guess you concerned about that expected/select_views_1.out is
>>> patched, not expected/select_views.out.
>>> I'm not sure the reason why regression test script tries to make diff
>>> between results/select_views and expected/select_views_1.out.
>>
>> select_views.out and select_views_1.out are alternate expected output
>> files.  The regression tests pass if the actual output matches either
>> one.  Thus, you have to patch both.
>>
> It was new for me. The attached patch updates both of the expected
> files, however, I'm not certain whether select_view.out is suitable, or
> not, because my results/select_view.out matched with expected/select_view_1.out.

Committed.  We'll see what the buildfarm thinks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company