Re: Inconsistencies around defining FRONTEND

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Andres Freund <andres@anarazel.de>

Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, samay sharma <smilingsamay@gmail.com>, Nazir Bilal Yavuz <byavuz81@gmail.com>

Date: 2022-08-23T21:24:30Z

Lists: pgsql-hackers

Attachments

v1-0001-Remove-define-FRONTEND-hacks.patch (application/octet-stream) patch v1-0001

On Sat, Aug 20, 2022 at 3:46 PM Andres Freund <andres@anarazel.de> wrote:
> Unfortunately, the remaining uses of FRONTEND are required. That's:
> - pg_controldata, via #define
> - pg_resetwal, via #define
> - pg_rewind, via -DFRONTEND, due to xlogreader.c
> - pg_waldump, via #define and -DFRONTEND, due to xlogreader.c, xlogstats.c, rmgrdesc/*desc.c

Actually, I think we could fix these pretty easily too. See attached.

This has been annoying me for a while. I hope we can agree on a way to
clean it up.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

Don't define FRONTEND for ecpg libraries
- 9352d5cf128a 16.0 landed
Don't define FRONTEND for initdb
- 06e3559bade1 16.0 landed
Don't define FRONTEND for libpq
- 1d77afefbd1d 16.0 landed