Horton

Re: [POC] A better way to expand hash indexes.

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Mithun Cy <mithun.cy@enterprisedb.com>
Cc: Bruce Momjian <bruce@momjian.us>, Amit Kapila <amit.kapila16@gmail.com>, David Steele <david@pgmasters.net>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-04-01T01:35:24Z
Lists: pgsql-hackers 
On Fri, Mar 31, 2017 at 1:15 AM, Mithun Cy <mithun.cy@enterprisedb.com> wrote:
> Thanks, I have tried to fix all of the comments.

Thanks.

Hmm, don't the changes to contrib/pageinspect/expected/hash.out
indicate that you've broken something?  The hash index has only 4
buckets, so the new code shouldn't be doing anything differently, but
you've got highmask and lowmask changing for some reason.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Fix formula in _hash_spareindex.

  2. Expand hash indexes more gradually.

  3. Change hash indexes to store only the hash code rather than the whole indexed