Re: isolationtester and 'specs' subdirectory
Robert Haas <robertmhaas@gmail.com>
From: Robert Haas <robertmhaas@gmail.com>
To: Josh Kupershmidt <schmiddy@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2013-06-25T16:15:01Z
Lists: pgsql-hackers
On Thu, Jun 20, 2013 at 7:10 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote: > I eventually tracked down the cause of this failure to a trailing ':' > in my $LIBRARY_PATH, which causes gcc to look inside the current > directory for a 'specs' file [1] among other things. Although I > probably don't need that trailing ':', it seems like we should avoid > naming this directory 'specs' nonetheless to avoid confusion with gcc. > > Renaming the 'specs' directory to something like 'isolation_specs' and > adjusting isolation_main.c accordingly lets me pass `make > check-world`. Proposed patch attached. This seems like pretty stupid behavior on the part of gcc. And, we're generally reluctant to rename things too blithely because it complicates back-patching. But on the flip side, back-patching changes to the isolation specs is probably a rare event. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company