Horton

Re: pg_verifybackup: TAR format backup verification

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Amul Sul <sulamul@gmail.com>, Sravan Kumar <sravanvcybage@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-10-01T16:06:19Z
Lists: pgsql-hackers 
On Tue, Oct 1, 2024 at 10:48 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Sure, I can try it on mamba's host.  It's slow though ...

OK, thanks.

> I apologize for rubbing you the wrong way on this.  It was not my
> intent.  (But, in fact, I had not realized you copied that code
> from somewhere else.)

That's good to hear, but I'm still slightly puzzled because you
started by complaining about the comment and the comment, as I read
it, says that it's copied. So either the comment isn't as clear as I
think it is, or you didn't read it before complaining about it. We
don't have to keep going back and forth on this. I'm happy to have you
change it in any way that you feel suitable, with or without adjusting
pg_rewind to match. There wouldn't have been a lengthy comment here if
I'd been certain what the right thing to do was; and I wasn't. If you
are, great!

-- 
Robert Haas
EDB: http://www.enterprisedb.com

Commits

  1. Adjust json_manifest_per_file_callback API in one more place.

  2. File size in a backup manifest should use uint64, not size_t.

  3. Fix some pg_verifybackup issues reported by Coverity.

  4. pg_verifybackup: Move some declarations to new pg_verifybackup.h

  5. pg_verifybackup: Move skip_checksums into verifier_context.

  6. Improve file header comments for astramer code.

  7. Move astreamer (except astreamer_inject) to fe_utils.

  8. Move recovery injector astreamer to a separate header file.

  9. Rename bbstreamer to astreamer.