Re: [HACKERS] UPDATE of partition key

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>

To: Amit Khandekar <amitdkhan.pg@gmail.com>

Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, pgsql-hackers <pgsql-hackers@postgresql.org>, Thomas Munro <thomas.munro@enterprisedb.com>

Date: 2018-01-19T20:36:14Z

Lists: pgsql-hackers

On Fri, Jan 19, 2018 at 4:37 AM, Amit Khandekar <amitdkhan.pg@gmail.com> wrote:
> Attached rebased patch.

Committed with a bunch of mostly-cosmetic revisions.  I removed the
macro you added, which has a multiple evaluation hazard, and just put
that logic back into the function.  I don't think it's likely to
matter for performance, and this way is safer.  I removed an inline
keyword from another static function as well; better to let the
compiler decide what to do.  I rearranged a few things to shorten some
long lines, too.  Aside from that I think all of the changes I made
were to comments and documentation.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Avoid referencing off the end of subplan_partition_offsets.
- 945f71db8452 11.0 landed
Allow UPDATE to move rows between partitions.
- 2f178441044b 11.0 landed
Remove useless lookup of root partitioned rel in ExecInitModifyTable().
- dca48d145e0e 11.0 cited
Factor error generation out of ExecPartitionCheck.
- 19c47e7c8202 11.0 landed
Minor preparatory refactoring for UPDATE row movement.
- ef6087ee5fa8 11.0 landed
Simplify and encapsulate tuple routing support code.
- cc6337d2fed5 11.0 landed
Avoid coercing a whole-row variable that is already coerced.
- 1c497fa72df7 11.0 landed
Use ResultRelInfo ** rather than ResultRelInfo * for tuple routing.
- 60f7c0abef03 11.0 landed
Make RelationGetPartitionDispatchInfo expand depth-first.
- 77b6b5e9ceca 11.0 cited
Expand partitioned tables in PartDesc order.
- 30833ba154e0 11.0 cited
Use a real RT index when setting up partition tuple routing.
- f81a91db4d1c 10.0 cited
Fix transition tables for partition/inheritance.
- 501ed02cf6f4 10.0 cited
Fix confusion about number of subplans in partitioned INSERT setup.
- 78a030a44196 10.0 cited
Prevent BEFORE triggers from violating partitioning constraints.
- 15ce775faa42 10.0 cited
Fire per-statement triggers on partitioned tables.
- e180c8aa8caf 10.0 cited
Fix reporting of violations in ExecConstraints, again.
- c0a8ae7be392 10.0 cited
Don't scan partitioned tables.
- d3cc37f1d801 10.0 cited
Allow FDWs to push down quals without breaking EvalPlanQual rechecks.
- 5fc4c26db512 9.6.0 cited