Horton

Re: allow_system_table_mods and DROP RULE

Robert Haas <robertmhaas@gmail.com>

View thread View on postgr.es
From: Robert Haas <robertmhaas@gmail.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-12-18T15:53:16Z
Lists: pgsql-hackers 
On Wed, Dec 18, 2019 at 3:56 AM Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> As a curious omission, DROP RULE does not check allow_system_table_mods.
>   Creating and renaming a rule does, and also creating, renaming, and
> dropping a trigger does.  The impact of this is probably nil in
> practice, but for consistency we should probably add that.  The patch is
> pretty simple.

+1. LGTM.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Disallow dropping rules on system tables by default