Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

Robert Haas <robertmhaas@gmail.com>

From: Robert Haas <robertmhaas@gmail.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Vladimir Rusinov <vrusinov@google.com>, Tom Lane <tgl@sss.pgh.pa.us>, Euler Taveira <euler@timbira.com.br>, David Steele <david@pgmasters.net>, Michael Paquier <michael.paquier@gmail.com>, Stephen Frost <sfrost@snowman.net>, Andres Freund <andres@anarazel.de>, Jim Nasby <Jim.Nasby@bluetreble.com>, Cynthia Shang <cynthia.shang@crunchydata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-01-26T17:21:08Z
Lists: pgsql-hackers

Attachments

On Tue, Jan 24, 2017 at 4:47 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> But I don't see any proposals to actually change all uses of "xlog" to
>> "wal".  What about program names, command line options, etc.?  If the
>> argument is, we changed one thing, we should change the rest, then let's
>> see that.  I think that argument itself is flawed, but if that's what
>> we're going with, let's see the whole plan.
>
> I'm happy to go change every last bit of it.  I was expecting after I
> committed the initial rename that somebody would provide a follow-on
> patch to do the rest of it in short order.  Instead, months went by
> and we still don't have a complete patch.  But I don't see why that
> has to take more than a day's work, probably just a few hours.  I'd
> like to do that and move on.

And here are patches for that.

0001 renames everything that contains "xlog" in pg_proc.h to refer to "wal".

0002 renames programs whose names contains "xlog".

0003 renames the dtrace probes whose names contain "xlog".

0004 renames command line options which contain "xlog".

There are probably a few more things that could be done afterwards to
clean up other odds and ends, but I think this gets the vast bulk of
the user-visible references to xlog.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. Remove all references to "xlog" from SQL-callable functions in pg_proc.

  2. Replace pg_shadow and pg_group by new role-capable catalogs pg_authid